Initialize map on declaration #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More idiomatic perhaps, but looks nicer in my opinion
thinkingserious
added
the
status: code review request
|
|
|
Cleaner code FTMFW You are welcome to make changes like this all day long if you want ;) |
|
Hello @Strum355, |
|
If i find any more things, ill be sure to throw a PR your way ;) already filled out the form from another PR so at this stage im just doing more stuff for the feel-good feeling haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More idiomatic perhaps, but looks nicer in my opinion