Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unstable widget test on windows/ubuntu #47

Merged
merged 61 commits into from
Feb 23, 2021

Conversation

sensuikan1973
Copy link
Owner

@sensuikan1973 sensuikan1973 commented Feb 23, 2021

resolve #46 partially

@sensuikan1973 sensuikan1973 changed the title investigate unstable widget test on windows investigate unstable widget test on windows/ubuntu Feb 23, 2021
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #47 (6e9f907) into main (a422a10) will decrease coverage by 4.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   76.46%   72.45%   -4.01%     
==========================================
  Files          28       28              
  Lines         667      668       +1     
==========================================
- Hits          510      484      -26     
- Misses        157      184      +27     
Impacted Files Coverage Δ
lib/engine/edax_asset.dart 79.16% <50.00%> (-4.17%) ⬇️
lib/engine/options/book_file_option.dart 77.77% <50.00%> (ø)
lib/engine/options/eval_file_option.dart 44.44% <50.00%> (ø)
lib/board/pedax_board.dart 85.71% <100.00%> (-3.33%) ⬇️
lib/home/book_file_path_setting_dialog.dart 90.00% <100.00%> (-10.00%) ⬇️
lib/board/square.dart 64.44% <0.00%> (-24.45%) ⬇️
lib/home/level_setting_dialog.dart 86.36% <0.00%> (-13.64%) ⬇️
lib/home/n_tasks_setting_dialog.dart 86.95% <0.00%> (-13.05%) ⬇️
... and 1 more

@sensuikan1973 sensuikan1973 changed the title investigate unstable widget test on windows/ubuntu fix unstable widget test on windows/ubuntu Feb 23, 2021
@sensuikan1973 sensuikan1973 marked this pull request as ready for review February 23, 2021 18:17
@sensuikan1973 sensuikan1973 merged commit 3b2f913 into main Feb 23, 2021
@sensuikan1973 sensuikan1973 deleted the investigate_unstable_test_on_windows branch February 23, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget Test on Windows is unstable
2 participants