Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gradle plugin to 4.10.0 #144

Merged
merged 5 commits into from
Aug 12, 2024
Merged

update gradle plugin to 4.10.0 #144

merged 5 commits into from
Aug 12, 2024

Conversation

sdzhong
Copy link
Contributor

@sdzhong sdzhong commented Aug 2, 2024

No description provided.

@sdzhong
Copy link
Contributor Author

sdzhong commented Aug 2, 2024

Resolves #139, see Trace

image

@sdzhong
Copy link
Contributor Author

sdzhong commented Aug 2, 2024

Network Event breadcrumb is not appearing: events 7.12.0 (gradle plugin v4.10.0) vs 7.6.0

image

@sdzhong
Copy link
Contributor Author

sdzhong commented Aug 5, 2024

Network Event breadcrumb is not appearing: events 7.12.0 (gradle plugin v4.10.0) vs 7.6.0

image

This appears to be a false alarm. I see some Network Event breadcrumbs by retrying without changing anything. https://demo.sentry.io/issues/5669560804/events/339e8772d1434647a83522cd0600d24e/

@sdzhong
Copy link
Contributor Author

sdzhong commented Aug 10, 2024

Thread discuss-demo

Aug 7, 2024
Simon (SE):

Hey team,
@Person_1 and I are wrapping up the Android :android: SDK upgrade before cutting a new release. Session Replay beta is available in the latest SDK version, and wanted to check with the team here: Do we want to have Session Replay enabled (and if so, at what %).
Some observations I've had, when enabling Session Replay are:
There seems to be additional overhead
The Replay video isn't visually accurate for the checkout nor user feedback popup, e.g. it shows a stretched User Feedback popup (screenshot)
The config to enable it are here, where we've set the setSessionSampleRate(1.0) and setErrorSampleRate(1.0). Should it be enabled and/or should the sample rates be adjusted?

image

Simon (SE):

CC @neil (SE) @kosty (SE)

Kosty (SE):

IMO if it's buggy in a way that will be obvious in a demo, probably let's hold off.
What would be the rationale for a sample rate between 1.0 and 0.0?

Simon (SE):

It could be nice to have a mobile/Android Session Replay available when customers are interested in seeing what's available atm (even while it's in beta).
The standard Android 3.x demo flow isn't affected by this, so having a lower sample rate (even 0.01) would mean we have a slow drip of new Replays appearing.

Neil (SE):

i would set (session) sampleRate to 1.0, just so we can make sure there is a session-replay for every event/span/etc. that we are looking at it
[^ we don't generate that much traffic via tda, so should be fine 🙂 ]

@sdzhong sdzhong marked this pull request as ready for review August 10, 2024 23:24
@sdzhong sdzhong requested a review from ndmanvar as a code owner August 10, 2024 23:24
@sdzhong
Copy link
Contributor Author

sdzhong commented Aug 10, 2024

resolves #142

@sdzhong sdzhong merged commit a642574 into main Aug 12, 2024
@sdzhong sdzhong deleted the update/4.10.0 branch August 12, 2024 18:51
This was referenced Aug 13, 2024
Copy link

sentry-io bot commented Aug 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ MainFragment$BackendAPIException: Failed to init delivery item workflow checkout [android] View Issue

Did you find this useful? React with a 👍 or 👎

@bruno-garcia
Copy link
Contributor

What supposedly the feedback form was:
image

Strange since we take screenshots of the app, not sure how something like this could happen.

Is it possible it recorded a different instance/device run?

@bruno-garcia
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants