Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forcing /checkout to fail via validate_inventory: "true" #152

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ndmanvar
Copy link
Collaborator

flask's /checkout does not error out unless you now pass it validate_inventory: "true" in the body

This change was made a few days ago via sentry-demos/empower#573

for some reason /checkout transaction was not being sent in the success case 🤷
regardless, adding validate_inventory: "true" gets us back to a working state in terms of error and transaction (see below)

image

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f7ce3a9) to head (f584096).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../example/vu/android/empowerplant/MainFragment.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #152   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         15      15           
  Lines        779     780    +1     
  Branches      43      43           
=====================================
- Misses       779     780    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndmanvar ndmanvar merged commit 6da8bd2 into main Sep 27, 2024
4 checks passed
@ndmanvar ndmanvar deleted the add-validate_inventory branch September 27, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant