-
-
Notifications
You must be signed in to change notification settings - Fork 158
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test lower node versions properly (#661)
previous CI setup wasn't actually running, it was throwing an uncaught rejection and somehow exiting with code 0 anyway getting vitest to work on node 12 was miles away from working, so moving the node version tests to the `test_tgz` job, which is a simpler test that ensures the basics work. Also adds some small fixes to the library itself to get it _closer_ to working, but the `glob` dependency is the sticking point for node 12. 14, 16, 18 are now fine. `glob` dependency will be replaced in #660 If getting node 12 to work proves impossible, we might need to just go to a v4 release but hopefully not.
- Loading branch information
Showing
6 changed files
with
20 additions
and
189 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,11 @@ | ||
module.exports = [ | ||
...require('eslint-plugin-mmkal').recommendedFlatConfigs, | ||
{ignores: ['lib/**', 'examples/**', 'test/generated/**']}, // | ||
{ | ||
rules: { | ||
// todo[>=4.0.0] drop lower node version support and remove these | ||
'unicorn/prefer-string-replace-all': 'off', | ||
'unicorn/prefer-at': 'off', | ||
}, | ||
}, | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.