Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow skipping re-runs #342

Merged
merged 4 commits into from
Oct 11, 2020
Merged

feat: allow skipping re-runs #342

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e53600
feat: allow skipping re-runs
mmkal Oct 7, 2020
582703a
type tests
mmkal Oct 7, 2020
de51d22
fix: lint
mmkal Oct 7, 2020
f5176f6
another type test
mmkal Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/umzug.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,10 @@ describe('types', () => {
});
});

test('rerun behavior is a map of its keys to themselves', () => {
expectTypeOf(RerunBehavior).toEqualTypeOf<{ readonly [K in RerunBehavior]: K }>();
});
Comment on lines +402 to +404
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, you've read my mind. I almost mentioned this in my last review, but I ended up thinking it would be too much hassle for you 😅 but you did it, that's even cooler.


test('up and down', () => {
const up = expectTypeOf(Umzug).instance.toHaveProperty('up');
const down = expectTypeOf(Umzug).instance.toHaveProperty('down');
Expand Down