fix: verify pending correctly for custom templates #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage 99.06% 99.07%
=======================================
Files 12 12
Lines 430 432 +2
Branches 90 90
=======================================
+ Hits 426 428 +2
Misses 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mmkal
commented
Aug 13, 2022
| }, | ||
| }); | ||
|
|
||
| await umzug.create({ name: 'test' }); |
There was a problem hiding this comment.
Should have pushed the test in a separate commit to prove this but: this was reproducing the bug described in #559 until the change to src/umzug.ts above.
mmkal
deleted the
mk/22/08/13/fixverifypendingcorrectlyforcustomtemplates
branch
|
Release v3.2.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559
CC @kf6kjg