Address review comments.

serhiy-storchaka · Jun 23, 2023 · 4ae982e · 4ae982e
1 parent c593435
commit 4ae982e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Objects/exceptions.c b/Objects/exceptions.c
@@ -211,7 +211,7 @@ BaseException_add_note(PyObject *self, PyObject *note)
     if (_PyObject_LookupAttr(self, &_Py_ID(__notes__), &notes) < 0) {
         return NULL;
     }
-    if (!notes) {
+    if (notes == NULL) {
         notes = PyList_New(0);
         if (notes == NULL) {
             return NULL;
@@ -221,7 +221,7 @@ BaseException_add_note(PyObject *self, PyObject *note)
             return NULL;
         }
     }
-    if (!PyList_Check(notes)) {
+    else if (!PyList_Check(notes)) {
         Py_DECREF(notes);
         PyErr_SetString(PyExc_TypeError, "Cannot add note: __notes__ is not a list");
         return NULL;

diff --git a/Python/pythonrun.c b/Python/pythonrun.c
@@ -1153,10 +1153,10 @@ print_exception_notes(struct exception_print_context *ctx, PyObject *value)
             res = PyFile_WriteObject(s, f, Py_PRINT_RAW);
             Py_DECREF(s);
         }
+        Py_DECREF(notes);
         if (PyFile_WriteString("\n", f) < 0) {
             res = -1;
         }
-        Py_DECREF(notes);
         return res;
     }
     Py_ssize_t num_notes = PySequence_Length(notes);