Skip to content
This repository has been archived by the owner on Apr 15, 2021. It is now read-only.

Cannot create new marketplace in Docker image with TomEE if Marketplace ID is empty #841

Closed
kwodzynski opened this issue Sep 22, 2017 · 8 comments

Comments

@kwodzynski
Copy link
Contributor

kwodzynski commented Sep 22, 2017

[Version]
OSCM 17.4.0
Docker image with TomEE

[How to reproduce]
Login as Platform Operator
Go to Create marketplace
Fill up Name and Organization ID
Click Save button

[Expected result]
New marketplace is created

[Observed result]
Red message "Value is required"
The marketplace is not created

[Details]

  • It is working with ESCM (as described above) and
  • in OSCM if I filled "Marketplace ID" field - but the field should not be required
@toshihiro-shiino
Copy link

toshihiro-shiino commented Sep 25, 2017

It does not reproduce in our environment.
Version: OSCM 17.4 / CE UNIT FOR GITHUB RELEASE-125-20170908121207

@ghost
Copy link

ghost commented Sep 25, 2017

@kwodzynski - I cannot reproduce this error either
Are you sure that you did not find the error that I already reported with tenant ID issue #831?

@kwodzynski
Copy link
Contributor Author

I forgot to write, it does occur on Docker image with TomEE. I have corrected the description of this bug and I will check it with environment with Glassfish 4.

@kwodzynski
Copy link
Contributor Author

Ok, I checked it with environment with Glassfish 4 in Internal and Saml mode. In both cases the functionality is working correctly, so it is probably problem with Docker image with TomEE.
@SylviaDehn I do not think that it is related with #831 because the Docker image is in Internal mode.

@kwodzynski kwodzynski changed the title Cannot create new marketplace in OSCM if Marketplace ID is empty Cannot create new marketplace in Docker image with TomEE if Marketplace ID is empty Sep 26, 2017
@GoebelL GoebelL added this to the 17.5-TomEE milestone Sep 27, 2017
@ghost
Copy link

ghost commented Oct 9, 2017

I also have this issue with TomEE

@grubskim grubskim self-assigned this Oct 16, 2017
@GoebelL
Copy link
Member

GoebelL commented Oct 16, 2017

This bug is evident. Marketplace ID has to be an optional field. The save button is correctly enabled as soon as the user fills the required organization. However the form validation refuses leaving the ID field blank. Please fix this logic.

grubskim pushed a commit that referenced this issue Oct 16, 2017
@grubskim
Copy link
Contributor

Added missing empty string check in \org\oscm\marketplace\bean\MarketplaceServiceBean.java.

@kwodzynski
Copy link
Contributor Author

Tested with Docker image 17.5 2017/11/02. It works correctly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants