Device monitor #368
Merged
Device monitor #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Jul 2, 2020
Manishearth
reviewed
Jul 8, 2020
backends/gstreamer/lib.rs
Outdated
| @@ -1,4 +1,6 @@ | |||
| #![feature(nll)] | |||
|
|
|||
| extern crate atomic_refcell; | |||
Manishearth
reviewed
Jul 8, 2020
| impl MediaDeviceMonitor for GStreamerDeviceMonitor { | ||
| fn enumerate_devices(&self) -> Result<Vec<MediaDeviceInfo>, ()> { | ||
| { | ||
| if let Some(ref devices) = *self.devices.borrow() { |
There was a problem hiding this comment.
we should probably file a followup about the devices changing
There was a problem hiding this comment.
though it's not that important, actually, sicne we don't use this cache in servo
|
@bors-servo r=Manishearth |
|
📌 Commit d298df9 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for https://github.com/servo/servo/pull/27152/files