Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icon #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add icon #35

wants to merge 1 commit into from

Conversation

robberphex
Copy link

And to make a dmg file:

$ pyinstaller --windowed -i icon/dwarf.icns dwex.py
$ create-dmg \
 --volname "dwex" \
 --window-pos 200 120 \
 --window-size 600 300 \
 --icon-size 100 \
 --icon "dwex.app" 175 120 \
 --hide-extension "dwex.app" \
 --app-drop-link 425 120 \
 "dist/dwex.dmg" \
 "dist/dmg/"

$ pyinstaller --windowed -i icon/dwarf.icns dwex.py
$ create-dmg \
 --volname "dwex" \
 --window-pos 200 120 \
 --window-size 600 300 \
 --icon-size 100 \
 --icon "dwex.app" 175 120 \
 --hide-extension "dwex.app" \
 --app-drop-link 425 120 \
 "dist/dwex.dmg" \
 "dist/dmg/"
@robberphex
Copy link
Author

This PR is trying to fix #12, and the preview dmg file is at https://github.com/robberphex/dwex/releases/tag/2.30 .

@sevaa
Copy link
Owner

sevaa commented Dec 19, 2022

Can you upload dmg files to the Mac App Store? I thought not.

@sevaa
Copy link
Owner

sevaa commented Dec 20, 2022

As for the icon, that's the logo from dwarfstd.org, isn't it? I don't think it will be a good app icon, seeing that it needs to scale from something like 16x16 (Windows taskbar) to 1000x1000 (app stores out there).

But that's fine, I have a design in mind that lends itself to a vector representation and will scale. Might not be a good design, but oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants