Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

cmd/shadowsocks-server: code refactor #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dylanchu
Copy link
Contributor

@dylanchu dylanchu commented Jul 8, 2018

Split codes into different files to get clearer interfaces and structures,
with only minor modifications.

@arthurkiller
Copy link
Collaborator

thanx for your contribute. But have you changed any core logic?

@dylanchu
Copy link
Contributor Author

dylanchu commented Jul 8, 2018

no core logic was changed, just some formal parameter changes on specific functions for decoupling,
like function run runUDP handleConnection updatePasswd. function updatePasswd was changed into method of type PasswdManager as it is only a series of manipulations on the type.

@dylanchu
Copy link
Contributor Author

dylanchu commented Jul 8, 2018

another consideration is functions in util.go should be small independent tools that don't rely on functions in the other three files. (but in fact still rely on global variables defined in server.go)

@dylanchu dylanchu changed the title code refactor cmd/shadowsocks-server: code refactor Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants