feat(update-issues): Process PRs as well as issues #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Shaka Player maintainers list has discussed in the past the idea of processing PRs as well as issues with our automated tools. I think it is particularly useful for managing stale PRs with the "waiting" tag. Changes to processing: - Do not skip PRs at a high level - Archive PRs with the same rules used for issues - Unarchive PRs with the same rules used for issues, except that PRs won't be automatically reopened - Close stale PRs with the same rules as issues, but with a different message (since PRs can't be automatically reopened in many cases) - Clean up "waiting" tags from closed PRs (same as issues) - Clean up "waiting" tags from PRs after a new comment (same as issues) PRs are excluded from these issue processing features: - Reopen issue by specially-formatted OP comment, since PRs can't be automatically reopened in many cases - Any rules for issues with the "question" tag, which wouldn't make sense for PRs - Automatic milestone management Changes to tests: - Set defaults for isPR, merged in mocks - Maintain basic state in mock methods (fixes several pre-existing test failures) - Add PR scenarios to test cases - Add missing test cases for pre-existing reopen features
theodab
requested changes
Jul 8, 2023
|
@theodab: ping! |
theodab
approved these changes
Jul 22, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Shaka Player maintainers list has discussed in the past the idea of processing PRs as well as issues with our automated tools. I think it is particularly useful for managing stale PRs with the "waiting" tag.
Changes to processing:
PRs are excluded from these issue processing features:
Changes to tests: