Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packager truncating WebM video files #210

Closed
paullewis opened this issue Mar 16, 2017 · 2 comments
Closed

Packager truncating WebM video files #210

paullewis opened this issue Mar 16, 2017 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@paullewis
Copy link

paullewis commented Mar 16, 2017

Issue

I'm finding that WebM files are being truncated by version 924d6d4-release. In particular I have a 720p WebM video that is truncated from 36,336,882 bytes to 35,648,887. The 1080p version of the same video is truncated even more severely: 72,773,711 bytes to 35,649,836 bytes.

Repro

Grab the following files:

  1. 720p WebM Video
  2. Vorbis video
# macOS bash
stat -f%z v-0720p-1800k-libvpx-vp9.webm # 36336882

And then run:

packager input=a-eng-0128k-libvorbis.webm,stream=audio,output=a-eng-0128k-libvorbis.webm \
         input=v-0720p-1800k-libvpx-vp9.webm,stream=video,output=v-0720p-1800k-libvpx-vp9.webm \
         --mpd_output example.mpd
# macOS bash
stat -f%z v-0720p-1800k-libvpx-vp9.webm # 35648887

System info

Operating System: 10.12.2 macOS Sierra and Ubuntu 14.04 trusty
FFMpeg: 3.2.2
libvpx: 1.6.1
packager: 924d6d4-release

@paullewis
Copy link
Author

If I don't have the packager overwrite the original files, but rather say, for example output=video.webm, everything works just fine.

@kqyang
Copy link
Contributor

kqyang commented Mar 16, 2017

Thanks for reporting the problem and including the detail repro instructions! Working on a fix now.

@kqyang kqyang added the type: bug Something isn't working correctly label Mar 16, 2017
@kqyang kqyang self-assigned this Mar 16, 2017
kqyang added a commit that referenced this issue Mar 17, 2017
Open output file in DoFinalize() to ensure that the input file has been
closed already.

Fixes #210

Change-Id: I935941b31c667e49be030c8da9f953d8387c7a9d
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 19, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants