Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolby Vision support #341

Closed
kqyang opened this issue Mar 6, 2018 · 6 comments
Closed

Dolby Vision support #341

kqyang opened this issue Mar 6, 2018 · 6 comments
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@kqyang
Copy link
Contributor

kqyang commented Mar 6, 2018

Dolby Vision Profiles: https://www.dolby.com/us/en/technologies/dolby-vision/dolby-vision-profiles-levels-v1-2-92-171021.pdf

Our priority is to add support for profile 5 (which is an HEVC Main10 single stream) first, which is the only required and pushed by Dolby right now as far as I know.

Look at Dolby's spec at https://www.dolby.com/us/en/technologies/dolby-vision/dolby-vision-bitstreams-within-the-iso-base-media-file-format.pdf, it seems trivial to add support for Dolby Vision Profile 5. What we need is to add support for Dolby Vision sample entries and Dolby Vision Configuration box. Everything else should be transparent.

@kqyang kqyang added the type: enhancement New feature or request label Mar 6, 2018
@kqyang kqyang added this to the v2.2 milestone Mar 6, 2018
@kqyang kqyang modified the milestones: v2.2, v2.3 Apr 27, 2018
@kqyang kqyang modified the milestones: v2.3, v2.4 Oct 24, 2018
@kqyang
Copy link
Contributor Author

kqyang commented Feb 6, 2019

astinus-1 pushed a commit that referenced this issue Mar 26, 2019
This is needed for Dolby Vision as Dolby Vision uses NAL unit type 62
to carry private information.

Issue #341.

Change-Id: Ib3f06d8f36ef3d89c33162dd74c012a0c3a805e5
@kqyang kqyang modified the milestones: v2.4, v2.5 Mar 28, 2019
@kqyang
Copy link
Contributor Author

kqyang commented Jul 17, 2019

@jigneshdhruv
Copy link

@kqyang Any update on this ticket? Can we expect DV/HDR+ support in Shaka Packager in the next release? Thanks.

@kqyang
Copy link
Contributor Author

kqyang commented Aug 7, 2019

@jigneshdhruv No. We'll update this issue if there are any updates.

shaka-bot pushed a commit that referenced this issue Oct 3, 2019
- Add relevant FOURCCs for Dolby Vision.
- Parse DOVIDecoderConfigurationRecord (dvcC, dvvC) to generate
  Dolby Vision codec string.
- Propagate Dolby Vision configs (dvcC, dvvC, hvcE) from Demuxer
  to Muxer.
- Add a Dolby Vision end to end test.

Support for backward compatibility signaling in DASH and HLS will be
added in a later CL.

Issue #341

Change-Id: If1385df5f48e04b59cb7661130bea48e26b453bf
shaka-bot pushed a commit that referenced this issue Oct 5, 2019
Issue #341.

Change-Id: I9665ba032b1e069500d866281cb8569ce59876f9
shaka-bot pushed a commit that referenced this issue Oct 15, 2019
Issue #341

Change-Id: I530b0768341e352f6ee0a1326540cd5712f01638
@kqyang kqyang modified the milestones: v2.5, v2.4 Dec 24, 2019
@kqyang
Copy link
Contributor Author

kqyang commented Dec 24, 2019

Dolby Vision is already supported. Move the work on Dolby Vision backward compatible profile to #690.

@kqyang kqyang closed this as completed Dec 24, 2019
astinus-1 pushed a commit that referenced this issue Feb 11, 2020
Added Dolby Vision backward compatible signalling, i.e. for Dolby Vision
profile 8, both base codec without Dolby Vision and HDR codec with Dolby
Vision are signalled.

This is achieved by using a new MuxerListener implementation
MultiCodecMuxerListener, which wraps multiple child MuxerListeners and
is able to delegate to the child MuxerListeners based on the codecs in
the stream.

Closes #341.

Change-Id: I1967bb1ed503087cdd011c364e5fb5647d516ca4
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 22, 2020
@shaka-project shaka-project locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants