Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize and align cue points from demuxed streams #355

Closed
kqyang opened this issue Mar 20, 2018 · 1 comment
Closed

Synchronize and align cue points from demuxed streams #355

kqyang opened this issue Mar 20, 2018 · 1 comment
Assignees
@vaage
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.1

Comments

@kqyang
Copy link
Contributor

kqyang commented Mar 20, 2018

Right now we only align cue points from multiplexed input streams. If demuxed streams are provided, cue points are not aligned across these streams, which would result in overlaps / gaps at multi-period boundary, which in turn leads to playback problems.

The misalignment is because for video streams, we push cue points forward to align with the next closest key frame; for demuxed audio or text streams, there are no key frame to align with, so the cue points are not adjusted => This results in cue points misalignment between Video and Audio/Text streams.
@kqyang kqyang added the type: enhancement New feature or request label Mar 20, 2018
@kqyang kqyang added this to the v2.1 milestone Mar 20, 2018
shaka-bot pushed a commit that referenced this issue Mar 22, 2018
@vaage @kqyang
Implements SyncPointQueue and CueAlignmentHandler
3b5b2bc 
SyncPointQueue manages all cue points and returns aligned cue
points to the callers (CueAlignmentHandlers).

CueAlignmentHandler is responsible for aligning cues from different
streams. It uses SyncPointQueue internally to align / synchronize the
cue points.

Issue: #355

Change-Id: I281fecb46a3ca7172d71e7495bdd07b8efdeb283
shaka-bot pushed a commit that referenced this issue Mar 26, 2018
@kqyang @vaage
Integrate CueAlignmentHandler
4e57259 
Also changed ChunkingHandler to be one-one handler.

Issue: #355

Change-Id: Ie98a96bcc0ddded347699c9f333f604826976d11
@kqyang kqyang closed this as completed Mar 28, 2018
kqyang pushed a commit that referenced this issue Mar 28, 2018
@vaage @kqyang
Implements SyncPointQueue and CueAlignmentHandler
e685c8a 
SyncPointQueue manages all cue points and returns aligned cue
points to the callers (CueAlignmentHandlers).

CueAlignmentHandler is responsible for aligning cues from different
streams. It uses SyncPointQueue internally to align / synchronize the
cue points.

Issue: #355

Change-Id: I281fecb46a3ca7172d71e7495bdd07b8efdeb283
kqyang added a commit that referenced this issue Mar 28, 2018
@kqyang
Integrate CueAlignmentHandler
e1bb27f 
Also changed ChunkingHandler to be one-one handler.

Issue: #355

Change-Id: Ie98a96bcc0ddded347699c9f333f604826976d11
@kqyang
Copy link
Contributor Author

kqyang commented Mar 29, 2018

Cherry-picked for v2.0.2.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 27, 2018
@shaka-project shaka-project locked and limited conversation to collaborators May 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vaage vaage

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
3 participants
@kqyang @shaka-bot @vaage