Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ad cues in text pipeline #362

Closed
kqyang opened this issue Mar 28, 2018 · 0 comments
Closed

Support Ad cues in text pipeline #362

kqyang opened this issue Mar 28, 2018 · 0 comments
Assignees
@vaage
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.2

Comments

@kqyang
Copy link
Contributor

kqyang commented Mar 28, 2018

Ad cues is already supported in audio/video pipeline, but not in text pipeline.
@kqyang kqyang added the type: enhancement New feature or request label Mar 28, 2018
@kqyang kqyang modified the milestones: v2.1, v2.2 Mar 28, 2018
shaka-bot pushed a commit that referenced this issue Mar 29, 2018
@vaage
Handle CueEvent in TextChunker
a11cbf9 
Updated TextChunker to handle incoming CueEvents. Connecting the
text chunker with the cue alignment handler will happen in a later
CL.

Issue: #362

Change-Id: Ib1fa9f457cf4ec0ce413dadcfa7eed5895ecd628
shaka-bot pushed a commit that referenced this issue Mar 29, 2018
@vaage
Add Cue Alignment For Segmented Text
7dd1574 
Added the cue alignment handler to the segmented text pipeline.

Issue: #362

Change-Id: If105e5310fa82d433c84692b967a93c1cdf148b0
shaka-bot pushed a commit that referenced this issue Apr 7, 2018
@vaage
Add CueEvent Support To WebVtt Output
061777d 
The WebVtt Output Handler did not recognize cue events. This change
allows the handler to accept the events and tell muxer listener
about them.

Issue #362

Change-Id: I7c3318b72e539adc19af587c8e213fdb0af8290b
shaka-bot pushed a commit that referenced this issue May 15, 2018
@vaage
Fix Cue Insertion at Text Stream End
2e9c2fe 
Problem : Text samples have variable length and therefore act
          more like continuous samples whereas audio and video
          act more like discrete samples. Since we use sample
          start time, a cue event could be inserted after the
          start time of the last text sample and never get
          inserted as there are no more samples.

Change : After all streams have requested flushing, we make sure
         to collect all remaining cue events from the sync point
         queue and insert them into each stream.

Issue #362

Change-Id: Id8f136f7ef53531f7a7f412613eac352324e0130
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 31, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vaage vaage

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
3 participants
@kqyang @shaka-bot @vaage