Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaka Packager sends an incorrect Content-Type header while making a key request #372

Closed
KristjanJ opened this issue Apr 5, 2018 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@KristjanJ
Copy link

KristjanJ commented Apr 5, 2018

System info

Operating System: Windows 10 build 1709
Shaka Packager Version: 2.0.2

Issue and steps to reproduce the problem

Shaka Packager makes a request to the Key Server using the HTTP header 'Content-Type: text/xml' while it is JSON content. In an older version it used to be 'application/x-www-form-urlencoded'. In any case, the correct one would be 'application/json'.

Packager Command:
packager-win
in=captain.mp4,stream=audio,init_segment=captain_audio/init.mp4,segment_template=captain_audio/$Number$.m4s
in=captain.mp4,stream=video,init_segment=captain/init.mp4,segment_template=captain/$Number$.m4s
-profile on-demand
-enable_widevine_encryption
-key_server_url "..."
-content_id "39643130376364632D373835612D343830392D626462612D363038303965373361333166"
-signer "widevine_test"
-aes_signing_key "..."
-aes_signing_iv "..."
-generate_static_mpd
-mpd_output captain.mpd

Extra steps to reproduce the problem?
None

What is the expected result?
Expected is that the Content-Type HTTP header has the value 'application/json' or is unspecified.

What happens instead?
Content-Type HTTP header has the value 'text/xml'.

@kqyang
Copy link
Contributor

kqyang commented Apr 6, 2018

Looks like there is a bug. @KristjanJ Thanks for letting us know the problem. We'll fix it.

@kqyang kqyang added type: bug Something isn't working correctly and removed needs triage labels Apr 6, 2018
@kqyang kqyang added this to the v2.1 milestone Apr 6, 2018
@kqyang kqyang self-assigned this Apr 6, 2018
kqyang pushed a commit that referenced this issue Apr 20, 2018
Content-Type for Widevine key request was incorrectly set to text/xml,
but it should be application/json.

Also added VLOGS for curl calls.

Fixes #372.

Change-Id: I4230795a582112c6d9c12883b5e61481b63284aa
@kqyang
Copy link
Contributor

kqyang commented Apr 20, 2018

Cherry-picked for v2.0.3.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 12, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants