-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VP9 codec name in manifest #469
Comments
It does not play because level is set to 0, which is not a valid value. It seems like a problem in your source stream. Can you share the source file and the packager command you used? You can email it to shaka-packager-issues@google.com if it cannot be shared publicly. We'll look into workaround the problem in Shaka Packager when seeing invalid level values in the source file. |
@lpluto Thanks for the content and FFmpeg information.
Unfortunately, FFmpeg does not fill in "level" in vp9 in ISO-BMFF on and before 4.0.2. It is fixed in FFmpeg/FFmpeg@5b6cc3a. I'll prepare a workaround in packager code. |
@lpluto Reply to your email to shaka-packager-issues@:
Thanks for trying out latest FFMpeg. Looks like there are still problems in latest FFmpeg in handling VP9 levels. "33" is not a valid level. I'll submit a fix to FFmpeg repository sometime this week. The workaround in packager code is done and will be pushed soon. |
@lpluto The workaround in packager has been merged! Let us know how it goes. |
Thank you @kqyang I created a stream using Shaka Packager with workaround and it plays on Shaka Player. Could you maybe let me know after you add a fix to FFMpeg? |
Sure, I will keep you posted. |
@lpluto The FFMpeg bug has just been fixed today: FFmpeg/FFmpeg@63c69d5 (coincidentally, another developer found the bug and fixed it). It will be included in FFMpeg v4.1 release. |
The VP9 level is computed when the container is missing a codec config or if the level is missing from the codec config. This fixes VP9 in ISO-BMFF files generated by FFmpeg v4.0.2 or earlier which does not have level set in the codec config. Fixes #469. Change-Id: I685bfd48be16ee6b2209da1c3173f7d6bb02b36a
Cherry-picked to v2.2.1. |
System info
Operating System: Ubuntu 16
Shaka Packager Version: v2.2.0
Issue and steps to reproduce the problem
I'm using MP4 with VP9 as source file to create a MPEG-DASH stream and in the manifest I have a codec name: "vp09.00.00.08.00.02.02.02.00", which seems not to be supported in players. When I change the codec name manually to "vp09.00.10.08" the stream plays in Shaka Player and Dashif players.
What is proper codec name for VP9?
KR,
Lukasz
The text was updated successfully, but these errors were encountered: