feat: Solution for adding startwithSAP/subsegmentstartswithSAP for audio tracks #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XingzhaoYun
changed the title
vish91
reviewed
Aug 30, 2023
| @@ -274,6 +274,14 @@ base::Optional<xml::XmlNode> AdaptationSet::GetXml() { | |||
| return base::nullopt; | |||
| } | |||
| } | |||
| if (subsegment_start_with_sap_ == 1) { | |||
There was a problem hiding this comment.
could you please add some tests and potentially since this is for spec compliance all the existing golden tests will also be regenrated once you can run those tests as well.
assuming this is for audio only and hence the subsegment check for just value == 1 ?
|
Please merge with |
This was referenced Feb 15, 2024
|
Replaced by #1346 1346 |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds startwithSAP/subsegmentstartswithSAP for aac, ac3, ec3 and ac4 audio tracks according to LIVE or VOD profile.