fix: webvtt single cue do not fail on EOS #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Jun 2, 2022
sr1990
pushed a commit
to sr1990/shaka-packager
that referenced
this pull request
Feb 18, 2023
While Parsing cue body check for the block size. If it's the last block do not error if it doesn't have a newline. Fixes shaka-project#1018
sr1990
pushed a commit
to sr1990/shaka-packager
that referenced
this pull request
Feb 18, 2023
While Parsing cue body check for the block size. If it's the last block do not error if it doesn't have a newline. Fixes shaka-project#1018
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1018
While Parsing cue body check for the block size.
If it's the last block do not error if it doesn't have a newline.