Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move all third-party deps into git submodules #1083

Merged
merged 7 commits into from
Aug 17, 2022

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Aug 16, 2022

This also normalizes the structure of all submodule folders so that
there is a clear place to put configurations, outside the submodule
source, but limited in scope to that folder.

Issue #1047 (New build system)

This also normalizes the structure of all submodule folders so that
there is a clear place to put configurations, outside the submodule
source, but limited in scope to that folder.
@joeyparrish
Copy link
Member Author

Needed some adjustment for various platforms once I had it up on GitHub, but it's building everywhere now. PTAL!

Copy link
Contributor

@kqyang kqyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a nit

@joeyparrish joeyparrish merged commit 1ff26b4 into shaka-project:cmake Aug 17, 2022
@joeyparrish joeyparrish deleted the more-submodules branch August 17, 2022 17:42
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants