Replace generate_static_mpd to generate_static_live_mpd
#672
Conversation
There was a problem hiding this comment.
Thanks for working on it. Can you add it to "https://github.com/google/shaka-packager/blob/master/packager/app/retired_flags.cc" to inform our users that the flag is retired? You can follow "generate_widevine_pssh" in that file.
packager/app/retired_flags.cc
Outdated
| @@ -35,9 +35,6 @@ DEFINE_int32( | |||
| num_subsegments_per_sidx, | |||
| 0, | |||
| "This flag is deprecated. Use --generate_sidx_in_media_segments instead."); | |||
| DEFINE_bool(generate_widevine_pssh, | |||
There was a problem hiding this comment.
Please don't remove this flag.
Add the retired flag 'generate_static_mpd' here in a similar way to 'generate_widevine_pssh' here.
There was a problem hiding this comment.
Sorry ... I mistaken ... 🙇
packager/app/retired_flags.cc
Outdated
| if (value) { | ||
| fprintf(stderr, | ||
| "WARNING: %s is deprecated and ignored. Please switch to " | ||
| "generate_static_live_mpd.\n", |
There was a problem hiding this comment.
can you add "--" before generate_static_live_mpd?
|
Sorry for not noticing it earlier. Please update the commands in the docs too, e.g. in https://github.com/google/shaka-packager/blob/master/docs/source/tutorials/dash.rst. Please do a source code search and replace all matchings. |
|
Thanks for the update. I believe there are others: https://github.com/google/shaka-packager/search?q=--generate_static_mpd&unscoped_q=--generate_static_mpd. Can you the ones in other *.rst too? Thanks. |
|
@Korilakkuma The pull request has been merged. Thanks a lot for your help! |
github-actions
bot
added
the
status: archived
Correspond to
TODOcomment.