Check type in unary operator expressions

sharkdp · Sep 11, 2023 · ca2b470 · ca2b470
1 parent c087a25
commit ca2b470
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/numbat/src/typechecker.rs b/numbat/src/typechecker.rs
@@ -395,18 +395,18 @@ impl TypeChecker {
             ast::Expression::UnaryOperator { op, expr, span_op } => {
                 let checked_expr = self.check_expression(expr)?;
                 let type_ = checked_expr.get_type();
+                let dtype = match &type_ {
+                    Type::Dimension(d) => d.clone(),
+                    _ => {
+                        return Err(TypeCheckError::ExpectedDimensionType(
+                            checked_expr.full_span(),
+                            type_.clone(),
+                        ))
+                    }
+                };
 
                 match *op {
                     ast::UnaryOperator::Factorial => {
-                        let dtype = match &type_ {
-                            Type::Dimension(d) => d.clone(),
-                            _ => {
-                                return Err(TypeCheckError::ExpectedDimensionType(
-                                    checked_expr.full_span(),
-                                    type_.clone(),
-                                ))
-                            }
-                        };
                         if dtype != DType::unity() {
                             return Err(TypeCheckError::NonScalarFactorialArgument(
                                 expr.full_span(),
@@ -1503,6 +1503,14 @@ mod tests {
         ));
     }
 
+    #[test]
+    fn boolean_values() {
+        assert!(matches!(
+            get_typecheck_error("-true"),
+            TypeCheckError::ExpectedDimensionType(_, _)
+        ));
+    }
+
     #[test]
     fn conditionals() {
         assert_successful_typecheck("if true then 1 else 2");