Remove allocations in Markup by switching to Cow<'static, str>
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now strings are only allocated if non-static (The vast majority of markup strings are `&'static`)
sharkdp
force-pushed
the
markup-allocations
branch
from
8ec97f2
to
d366ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now strings are only allocated if non-static. (The vast majority of markup strings are
&'static.)There is of course a cost associated with this, the cost of checking the
Cowvariant, but given the number of static strings in use for markup, there's no way that this is a greater cost than allocating those as strings.