Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter SystemType to GetStaticPortInfo of IPoweredUpDevice #98

Closed
tthiery opened this issue Oct 4, 2020 · 0 comments · Fixed by #99
Closed

Add parameter SystemType to GetStaticPortInfo of IPoweredUpDevice #98

tthiery opened this issue Oct 4, 2020 · 0 comments · Fixed by #99
Assignees
@tthiery
Labels
area-device-hubdevices area-devices enhancement New feature or request
Milestone
v3.1 (non-breaking)

Comments

@tthiery
Copy link
Member

tthiery commented Oct 4, 2020 •
edited
Loading

Some devices, despite being identical in behavior and IOTypeId have different properties on different hubs. Examples are Voltage and Current. Their value ranges (and amount of zeros for the names/units) differ because the hubs use different batteries.

To enhance the devices to reflect these, different static port info, we add an overload for the GetStaticPortInfo with a backward compatible forward.

Requirement for MarioHub (#91) and TwoPortHub (#39)
@tthiery tthiery added this to the v3.1 (non-breaking) milestone Oct 4, 2020
@tthiery tthiery self-assigned this Oct 4, 2020
tthiery added a commit that referenced this issue Oct 5, 2020
@tthiery
Add known SystemType to LegoWirelessProtocol
6ab755b 
- Known SystemType allows the protocol to react to HubAttachedIO w/
  the right static port data specified for a given device.
- Adjusted existing IPoweredUpDevice

#98 non-breaking (internal API, default values)
@tthiery tthiery mentioned this issue Oct 5, 2020
Merged
tthiery added a commit that referenced this issue Oct 5, 2020
@tthiery
Add known SystemType to LegoWirelessProtocol (#99)
290a929 
- Known SystemType allows the protocol to react to HubAttachedIO w/
  the right static port data specified for a given device.
- Adjusted existing IPoweredUpDevice

#98 non-breaking (internal API, default values)
tthiery added a commit that referenced this issue Oct 5, 2020
@tthiery
Fix initialization of protocol in CLI
64af556 
#98 non-breaking
@tthiery tthiery mentioned this issue Oct 5, 2020
Merged
tthiery added a commit that referenced this issue Oct 5, 2020
@tthiery
Fix initialization of protocol in CLI (#100)
0c7b07b 
#98 non-breaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthiery tthiery

Labels
area-device-hubdevices area-devices enhancement New feature or request
Projects
None yet
Milestone
v3.1 (non-breaking)
Development

Successfully merging a pull request may close this issue.

Add known SystemType to LegoWirelessProtocol sharpbrick/powered-up
1 participant
@tthiery