Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multiple Target Frameworks to CLI projects #172

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

tthiery
Copy link
Member

@tthiery tthiery commented Apr 22, 2021

  • Fixed Examples, CLI, TestScript Projects
  • Fixed the documentation

#155 breaking

- Fixed Examples, CLI, TestScript Projects
- Fixed the documentation

#155 breaking
@tthiery
Copy link
Member Author

tthiery commented Apr 22, 2021

@dkurok Can you have a look into this?

This approach multi-targets the command line projects. it has the disadvantage of requiring more command line parameters for normal use (e.g. dotnet tool install -g --framework .... and dotnet run -f xxx -- device list) but it brings tons of benefits

  • Multiple adapters are compiled into the solution
  • Linux works with the CLI projects (especially upcoming bluez)
  • We get as a side job a powerdup.json support.

I basically took the benefits of the other PR while using multi-targeting instead of plugin loading.

- Added overloads to use IConfiguration
- Added Injections of Options into BlueGigaBluetoothBLEAdapter
- Fixed existing code bases to better reflect this

#122 non-breaking
@tthiery tthiery merged commit 1e2e4dd into master Apr 30, 2021
@tthiery tthiery deleted the issue-155-configuration branch April 30, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant