Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] cs-229-deep-learning #80

Merged
merged 14 commits into from
Nov 15, 2020
Merged

Conversation

rickiepark
Copy link
Contributor

Working in progress. :)

@shervinea shervinea added the in progress Work in progress label Oct 19, 2018
@rickiepark
Copy link
Contributor Author

@shervinea I finish translation of deep learning. :)

@shervinea
Copy link
Owner

Awesome work @rickiepark!

Now, let's wait for a reviewer to come and take a look at the translation.

@shervinea shervinea added reviewer wanted Looking for a reviewer and removed in progress Work in progress labels Oct 20, 2018
@rickiepark
Copy link
Contributor Author

👍

@shervinea shervinea changed the title [ko] Deep learning [ko] cs-229-deep-learning Oct 6, 2020
@kimdanny
Copy link
Contributor

kimdanny commented Nov 14, 2020

@shervinea I've reviewed his work on cs-229-deep-learning translation, and it was perfect. Couldn't find any line to point out. Actually @rickiepark is a professional translator who is very well known in South Korea :)
I reckon we can close this PR now and merge into master

Copy link
Contributor

@kimdanny kimdanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect translation!

@shervinea
Copy link
Owner

Thanks @kimdanny for your review, and thanks again @rickiepark for your work great work!

@shervinea shervinea merged commit 0cdfd67 into shervinea:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewer wanted Looking for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants