Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Capabilities and Attribute Handling #17

Closed
pwood opened this issue Apr 28, 2021 · 1 comment
Closed

Rework Capabilities and Attribute Handling #17

pwood opened this issue Apr 28, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pwood
Copy link
Member

pwood commented Apr 28, 2021

At the moment most capabilities are overly complicated for the task that they do, that is:

  • Be able to issue ZCL Commands.
  • Periodically read attributes, and/or wait for attribute reports.

The current system of having attribute monitors attempts to hide much of the ZCL, that it does, but they are cumbersome to use. This results in overly complicated EnumerateDevice callbacks that should be relatively simple.

Further, because the aim is to support any device that supports a ZCL Cluster correctly, we must store details such as the endpoint and if polling is required (when a report attribute set up fails).

But there is some proprietary support that does not really need to make use of this, such as knowing that a device will always report an attribute on the Basic cluster on endpoint 0 of a device. If we know the device for example, we don't need to store that it requires its proprietary support, we can just assume that based on the device identity.

Ideally we need to simplify this, and make use of the configuration objects consistent.

@pwood pwood added the enhancement New feature or request label Apr 28, 2021
@pwood pwood self-assigned this Apr 28, 2021
pwood added a commit that referenced this issue Apr 28, 2021
…d pressure along with the battery status.

This work gives rise to #17, as this was unpleasant to work on and needs a good refactor.
@pwood
Copy link
Member Author

pwood commented Jan 14, 2024

This is being addressed by #20.

@pwood pwood closed this as completed Jan 14, 2024
pwood added a commit that referenced this issue Jun 14, 2024
…d pressure along with the battery status.

This work gives rise to #17, as this was unpleasant to work on and needs a good refactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant