Update minor version to 5.4.1 and use unix_timestamp instead of now #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danpoage
commented
Jan 8, 2021
danpoage
commented
- Correctly report minor version as 1 so the full version is 5.4.1
- Added changelog for minor update
- Use UNIX_TIMESTAMP() instead of NOW() in order_tracking_number insert as the creationDate column is an integer
added 2 commits
January 8, 2021 14:30
…to use an integer timestamp instead of a string. Changed the minor version in both the Main.php and main.yaml to 1 as the current version of the plugin is actually 5.4.1.
jeversmann-shipstation
approved these changes
Jan 8, 2021
jbolton209
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.