Avoid generating duplicate element IDs

Closes #567.
shrinerb · Feb 19, 2022 · b0f5624 · b0f5624
1 parent b5e41b7
commit b0f5624
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -80,7 +80,7 @@ allow users to upload files:
 
 ```erb
 <%= form_for @photo do |f| %>
-  <%= f.hidden_field :image, value: @photo.cached_image_data %>
+  <%= f.hidden_field :image, value: @photo.cached_image_data, id: nil %>
   <%= f.file_field :image %>
   <%= f.submit %>
 <% end %>

diff --git a/doc/carrierwave.md b/doc/carrierwave.md
@@ -646,7 +646,7 @@ Shrine.plugin :cached_attachment_data
 ```
 ```rb
 form_for @photo do |f|
-  f.hidden_field :image, value: @photo.cached_image_data
+  f.hidden_field :image, value: @photo.cached_image_data, id: nil
   f.file_field :image
 end
 ```

diff --git a/doc/getting_started.md b/doc/getting_started.md
@@ -93,7 +93,7 @@ validation errors and for potential [direct uploads].
 <!--Rails form builder-->
 ```rb
 form_for @photo do |f|
-  f.hidden_field :image, value: @photo.cached_image_data
+  f.hidden_field :image, value: @photo.cached_image_data, id: nil
   f.file_field :image
   f.submit
 end

diff --git a/doc/multiple_files.md b/doc/multiple_files.md
@@ -180,7 +180,7 @@ album/photos as well (they will be submitted under the
 form_for @album, html: { enctype: "multipart/form-data" } do |f|
   f.text_field :title
   f.fields_for :photos do |p| # adds new `album[photos_attributes]` parameter
-    p.hidden_field :image, value: p.object.cached_image_data
+    p.hidden_field :image, value: p.object.cached_image_data, id: nil
     p.file_field   :image
     p.check_box    :_destroy unless p.object.new_record?
   end

diff --git a/doc/refile.md b/doc/refile.md
@@ -458,7 +458,7 @@ Shrine.plugin :cached_attachment_data
 ```
 ```rb
 form_for @user do |form|
-  form.hidden_field :profile_image, value: @user.cached_profile_image_data
+  form.hidden_field :profile_image, value: @user.cached_profile_image_data, id: nil
   form.file_field :profile_image
 end
 ```
@@ -475,7 +475,7 @@ Shrine.plugin :remove_attachment
 ```
 ```rb
 form_for @user do |form|
-  form.hidden_field :profile_image, value: @user.cached_profile_image_data
+  form.hidden_field :profile_image, value: @user.cached_profile_image_data, id: nil
   form.file_field :profile_image
   form.check_box :remove_profile_image
 end
@@ -491,7 +491,7 @@ Shrine.plugin :remote_url
 ```
 ```rb
 form_for @user do |form|
-  form.hidden_field :profile_image, value: @user.cached_profile_image_data
+  form.hidden_field :profile_image, value: @user.cached_profile_image_data, id: nil
   form.file_field :profile_image
   form.text_field :profile_image_remote_url
 end

diff --git a/doc/release_notes/2.1.0.md b/doc/release_notes/2.1.0.md
@@ -51,7 +51,7 @@ end
 
 ```rb
 form_for @photo do |f|
-  f.hidden_field :image, value: @photo.cached_image_data
+  f.hidden_field :image, value: @photo.cached_image_data, id: nil
   f.file_filed :image
 end
 ```