Add directive support #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Situations where only a directive is present requires the GraphQLName to search directly for the `@` rune. Example: name `graphql:"name @Skip(if: skipThis=true)"`
The strings.Index check for "@" is the third separator we look for. There's no reason to look separately, since we just want the first field name separator. Add test covering a GraphQL directive that immediately follows the field name.
|
Thanks, this change makes sense. I'll refactor it slightly and add a test before merging. |
dmitshur
approved these changes
Jun 6, 2022
hgiasac
pushed a commit
to hasura/go-graphql-client
that referenced
this pull request
Apr 8, 2023
Also consider "@" when looking for the end of the field name, since
GraphQL directives can follow a field name immediately without any
arguments or aliases being involved. For example:
query {
me {
firstName
lastName @include(if: $expandedInfo)
}
}
The strings.Index check for "@" is the third separator we look for.
There's no reason to look separately, since we just want the first
field name separator.
Add test covering a GraphQL directive that immediately follows the
field name.
Co-authored-by: Dmitri Shuralyov <dmitri@shuralyov.com>
GitHub-Pull-Request: shurcooL#94
hgiasac
pushed a commit
to hasura/go-graphql-client
that referenced
this pull request
Apr 8, 2023
Also consider "@" when looking for the end of the field name, since
GraphQL directives can follow a field name immediately without any
arguments or aliases being involved. For example:
query {
me {
firstName
lastName @include(if: $expandedInfo)
}
}
The strings.Index check for "@" is the third separator we look for.
There's no reason to look separately, since we just want the first
field name separator.
Add test covering a GraphQL directive that immediately follows the
field name.
Co-authored-by: Dmitri Shuralyov <dmitri@shuralyov.com>
GitHub-Pull-Request: shurcooL#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situations where only a directive is present requires the GraphQLName to search directly for the
@rune.Example: name
graphql:"name @skip(if: skipThis=true)"This issues allows the following to succeed:
type TeamsQuery struct { Organization struct { ID githubv4.String Teams struct { Nodes []struct { ID githubv4.String DatabaseID githubv4.Int Slug githubv4.String Name githubv4.String Description githubv4.String Privacy githubv4.String Members struct { Nodes []struct { Login githubv4.String } + } `graphql:"members @skip(if: $summaryOnly)"` Repositories struct { Nodes []struct { Name githubv4.String } + } `graphql:"repositories @skip(if: $summaryOnly)"` } PageInfo PageInfo } `graphql:"teams(first:$first, after:$cursor, rootTeamsOnly:$rootTeamsOnly)"` } `graphql:"organization(login:$login)"` }