Updates to Tables spec #1

annatisch · 2020-05-05T15:03:29Z

Addresses the comments from PR Azure#8151

christothes

LGTM - Just the outstanding question on the merge operation.

christothes · 2020-05-05T18:27:33Z

specification/cosmos-db/data-plane/Microsoft.TablesStorage/preview/2019-02-02/table.json

+        "produces": [
+          "application/json"
+        ],
+        "operationId": "Table_MergeEntity",


Should we hold off on implementing this until there is support for the merge verb in autorest? It seems that it is only truly supported as documented by storage.

Based on the meeting this morning - it seems that we should optimize for the Storage experience, so I'm in favour of leaving it in, even if Cosmos doesn't support it.

specification/cosmos-db/data-plane/Microsoft.TablesStorage/preview/2019-02-02/table.json

lmazuel · 2020-05-05T21:41:03Z

specification/cosmos-db/data-plane/Microsoft.TablesStorage/preview/2019-02-02/table.json

@@ -207,13 +230,19 @@
        "tags": [
          "table"
        ],
+        "consumes": [
+          "application/json"


Need to override application/json;odata=minimalmetadata?

Yeah... maybe not essential as I don't know what the service does with the extra odata tag - however the documented header here is just "application/json"

annatisch · 2020-05-06T16:57:56Z

@shurd - this PR should be good to go if you have no additional comments/concerns.

specification/cosmos-db/data-plane/Microsoft.TablesStorage/preview/2019-02-02/table.json

* aws connector in asc including API and examples - draft 1 * adding 'state' to the connector * when deleting aws connector that is not exist, return 404 * Updating connector is in put * aws connector status updated to enum * deleting post option in aws connector * aws connector adding state to the example files * adding description to aws connector * Renaming awsConnectors to connectors * renaming example files to connector without aws * aws dropped from the connector and adding connector type * update examples of connector based in the new schema * adding proxy to arc onboarding * updating example files * fixing typo * fixing arc to hybridComputeAutoProvision * update connectors.json (#1) * fixing file structure * updating examples * fixing connectorType to authenticationType * adding another block of properites * making two parts in the connector settings * updating required fields * Adding permission list * fixing error * changing name object * fixing permission name * adding all service principal fields * update documentation of app serivce secret * creating examples * location changed to region * create example changed to createupdate * moving account id insode the connection object * remove name fields in hybrid compute * Adding base for aws onboarding * two put and update examples * fixing examples based new body * fixing connector name * fixing aws connctor example * fixing readme and link to example file * adding correct example file * fixin example extension * fixing discriminator * provisioningState is required prop * fixing link in readme file * fixing typo in connectorName * fixing provisioningState * fixin authenticationType to authenticationType * removing readonly fields from examples * fixing credential fields * remove id from create * run Prettier on the files * running prettier * create two different x-ms-enum * update examples of connectors * update readme file * removing custom from secure score * fifixng enum permission prop * fixing extra space in readme * Adding gcp connector * adding gcp example * update example of get list * fixing name * running prettier * fixing errors of build * removing null values from examples * taking secureScore.json new file * all secret fields marked as format password * remove required fields * Adding relavent required fields * remove password format * writeonly fields are returned with <empty> value * fixing gcp connector fields * fixing delete response * fiximng examples to return empty string on writeonly fields * fixing delete response in the example * change structure of authentication * fixing inheretence in aws * fixing structure of cred in aws and gcp * write only fields are empty strings in the response of the examples * after Prettier check * clarifing the documentation of two fields * fixing documentation of region field in hybrid compute. Co-authored-by: Ayman Jarrous <ayjarrou@microsoft.com> Co-authored-by: adzamri <49613774+adzamri@users.noreply.github.com>

annatisch added 3 commits May 4, 2020 17:55

Updates to tables spec

9f6c2cf

Fixed indentation

ad4d117

Removed storage references

0e564c7

christothes reviewed May 5, 2020

View reviewed changes

annatisch commented May 5, 2020

View reviewed changes

specification/cosmos-db/data-plane/Microsoft.TablesStorage/preview/2019-02-02/table.json Show resolved Hide resolved

christothes approved these changes May 5, 2020

View reviewed changes

annatisch added 2 commits May 5, 2020 14:16

Grammar

0fbf6cd

Improved match condition description

dd4f3e9