feat: support js runtime for unit resolver #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboure
reviewed
Sep 16, 2023
src/resources/Resolver.ts
Outdated
| this.config.kind === 'UNIT' || | ||
| 'request' in this.config || | ||
| 'response' in this.config | ||
| ); | ||
|
|
||
| if (!isJsResolver) { | ||
| if (!isUnitJsResolver && !isPipelineJsResolver) { |
There was a problem hiding this comment.
It's been a while since I wrote this code and with this change it became hard to wrap my head around it..
If I read this correctly, we should now be able to simplify this condition to something like isVTLResolver where
const isVTLResolver = 'request' in this.config || 'response' in this.config;
There was a problem hiding this comment.
Thanks.
I added isVTLResolver flag.
|
@bboure thank you for review. |
bboure
reviewed
Sep 26, 2023
doc/resolvers.md
Outdated
| @@ -49,7 +49,18 @@ export function response(ctx) { | |||
| } | |||
| ``` | |||
|
|
|||
| To use [direct lambda](https://docs.aws.amazon.com/appsync/latest/devguide/direct-lambda-reference.html), set `kind` to `UNIT` and don't specify `request` and `response` (only works with Lambda function data sources). | |||
| If you want to use a UNIT JavaScript resolver, you must specify `code` (the minimalistic resolver handler cannot be used for UNIT resolver). | |||
There was a problem hiding this comment.
What do you mean by "minimalistic" ?
|
Thank you @krml4913 |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support javascript runtime for unit resolver.
https://aws.amazon.com/jp/blogs/mobile/aws-appsync-now-supports-javascript-for-all-resolvers-in-graphql-apis/
Closes #616