Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main-renderer): fixes spinner showing on google login (#105) #106

Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix(main-renderer): fixes spinner showing on google login (#105) #106

merged 1 commit into from
Nov 14, 2019

Conversation

btaens
Copy link
Contributor

@btaens btaens commented Jul 24, 2019

📋 Description

A simple fix for issue #105 where the "Connecting" spinner fades in on Google login.

🗂 Type

  • 🍾 Feature
  • 🚨 Bugfix
  • 📒 Documentation
  • 👷 Internals

🔥 Severity

  • 💎 Non-Breaking Changes
  • 💔 Breaking Changes

🖥 Platforms

  • 🍏 macOS
  • 💾 Windows
  • 🐧 Linux

🛃 Tests

  • My changes have been tested manually.
  • My changes are covered by automated testing methods.

👨‍🎓 Miscellaneous

  • My changes follow the style guide.
  • My changes require updates to the documentation.

@sidneys
Copy link
Owner

sidneys commented Nov 14, 2019

@btaens Thank you very much! Merging.

@sidneys sidneys merged commit cd142e0 into sidneys:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btaens @sidneys