feat: Configure target ECS cluster ARN #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limess
requested changes
Apr 27, 2021
There was a problem hiding this comment.
Thanks for the contribution!
We don't spend a lot of time maintaining this or checking for notifications, but this looks like a sensible improvement so I'll try to help you get it in.
It'd be useful if you were to also update the README with the new option. I'm aware that's a little bit messy right now so don't worry about placement too much.
|
I've made the changes to the best of my knowledge. I'll test these in my own setup and fix any issues that come up. Otherwise, I'd also appreciate a second review anytime :) |
Limess
requested changes
Apr 27, 2021
Limess
reviewed
May 14, 2021
|
Merged, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuring a specific ECS cluster to monitor, using the
--cluster=ARNCLI argument.Fixes #13
If someone could point out how to adjust the log line during startup to include this setting, I'd be happy to include it.