Release verification with both (.sig, .crt) + .sigstore
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Leightcap <jack.leightcap@trailofbits.com>
jleightcap
commented
Mar 3, 2023
| @@ -91,7 +100,7 @@ jobs: | |||
| needs: [build] | |||
| name: Generate build provenance | |||
| permissions: | |||
| actions: read # To read the workflow path. | |||
| actions: read # To read the workflow path. | |||
There was a problem hiding this comment.
(Ran prettier over source)
|
Not sure what the correct procedure is for kicking off a test release build -- verified the contents of |
jleightcap
changed the title
.sig, .crt) + .sigstore`.sig, .crt) + .sigstore
We can merge here and do a release candidate -- that would probably be the easiest way. |
|
I'll shepherd this + do a RC. |
|
Thanks Will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #509