Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVPWM with midpoint clamp #309

Merged
merged 5 commits into from
Sep 23, 2023
Merged

Conversation

Candas1
Copy link
Collaborator

@Candas1 Candas1 commented Sep 13, 2023

Hi @runger1101001 and @askuric,

Hope this is the right way to contribute.
This is what I proposed here.

Before the change:
RAM: [= ] 9.2% (used 4536 bytes from 49152 bytes)
Flash: [=== ] 27.1% (used 71076 bytes from 262144 bytes)
loopfoc takes up to 220us with SVPWM

After the change:
RAM: [= ] 9.2% (used 4536 bytes from 49152 bytes)
Flash: [=== ] 26.6% (used 69676 bytes from 262144 bytes)
loopfoc takes up to 156us with SVPWM
loopfoc takes up to 152us with SinePWM

I only saw a very small difference in magnitude between the old and new SVPWM without center modulation.
With center modulation it's exactly the same.

I decide to just add SVPWM to the SinePWM code and not duplicate all the code.

@runger1101001
Copy link
Member

I'm on-board with this. The question is whether we want to put it in this release (2.3.1) which is very close to happening, or merge it to the dev branch afterwards, for the 2.4.0 release?

@Candas1
Copy link
Collaborator Author

Candas1 commented Sep 18, 2023

I wouldn't want to mess up with the 2.3.1 release if there is not enough feedback about my change.
I will continue using the dev branch after the release.

@runger1101001
Copy link
Member

Just waiting for the Arduino library manager to pick up the new release, make sure everything is ok, and then I will merge this to the dev branch...

@Candas1
Copy link
Collaborator Author

Candas1 commented Sep 23, 2023

Take your time. Thanks for the new release.

@runger1101001 runger1101001 merged commit 1694fa3 into simplefoc:dev Sep 23, 2023
16 checks passed
@Candas1 Candas1 deleted the SVPWM_midpoint branch January 23, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants