Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending of metadata with sendFile #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samsont
Copy link

@samsont samsont commented Apr 11, 2016

When you send a file: added the ability to send metadata with the file. The functionality was already in place, just added a spot for the additional data.

If you send a file: added the ability to send metadata about the file. The functionality was already in place, just added a spot for the additional data.
@xdumaine
Copy link
Contributor

I like this. @latentflip?

@tgabi333
Copy link
Contributor

i would rather call metadata the passed parameter everywhere instead of additionalData

@samsont
Copy link
Author

samsont commented May 27, 2016

I agree with the comment on metadata. The challenge is that on the receiving side, there already is a variable called metadata. (https://github.com/otalk/filetransfer/blob/master/filetransfer.js) . There is a metadata.size and a metadata.name. I access the information I proposing to add as: metadeta.additionalData,

A simpler thing to do might be that instead of using what I wrote:
Peer.prototype.sendFile = function (file, metadata)
Instead to use
Peer.prototype.sendFile = function (file, additionalData)
to keep the same name all the way through.

If I made that change, might that be ok?

Thanks!

@tgabi333
Copy link
Contributor

tgabi333 commented Jun 7, 2016

maybeadditionalInfo?

@fippo
Copy link
Contributor

fippo commented Jun 7, 2016

I think its safe to call this metadata, this should not conflict with the use of that name in filetransfer?

@jayaprabhakar
Copy link

Any plans on merging this change? It has been two years, so I am curious. I want this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants