This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
feat(dap): load dap lazily #388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MunifTanjim
added a commit
to MunifTanjim/rust-tools.nvim
that referenced
this pull request
May 27, 2023
IndianBoy42
reviewed
Jul 12, 2023
| @@ -17,7 +22,7 @@ function M.get_codelldb_adapter(codelldb_path, liblldb_path) | |||
| } | |||
| end | |||
|
|
|||
| function M.setup_adapter() | |||
| local function setup_adapter() | |||
There was a problem hiding this comment.
Why is making it private necessary?
There was a problem hiding this comment.
It's not. What's the usecase for making it public?
There was a problem hiding this comment.
- It already was so without any reason you should keep it the same
- The user could call setup themselves whenever they want (which btw the loaded check maybe could be inside setup_adapter?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.