Ignore single space indents #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
brandon93s
commented
May 24, 2021
| let indents = makeIndentsMap(string, true); | ||
| if (indents.size === 0) { | ||
| indents = makeIndentsMap(string, false); | ||
| } |
There was a problem hiding this comment.
I'm protecting against introduction of another edge case here where a file truly is single space indented intentionally. Since makeIndentsMap calculates relative indents accounting for this inline would've sacrificed code clarity. Trading off for a second parsing run here in the interest of limiting complexity.
There was a problem hiding this comment.
Can you add this as a code comment?
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30