Document reduceRight alternative for no-array-reduce
#2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
no-array-reduceno-array-reduce
fisker
previously approved these changes
Sep 29, 2024
fregante
commented
Sep 29, 2024
rules/no-array-reduce.js
Outdated
| @@ -4,7 +4,7 @@ const {isNodeValueNotFunction, isArrayPrototypeProperty} = require('./utils/inde | |||
|
|
|||
| const MESSAGE_ID = 'no-reduce'; | |||
| const messages = { | |||
| [MESSAGE_ID]: '`Array#{{method}}()` is not allowed', | |||
| [MESSAGE_ID]: '`Array#{{method}}()` is not allowed. Prefer other types of loop for readability.', | |||
There was a problem hiding this comment.
I’ll alter this message to specifically mention .toReversed() for reduceRight. #2428 isn’t out yet so it’s possible that they will use .reverse() instead.
fregante
commented
Sep 29, 2024
| @@ -104,8 +106,7 @@ const create = context => { | |||
| const methodNode = getMethodNode(callExpression); | |||
| yield { | |||
| node: methodNode, | |||
| messageId: MESSAGE_ID, | |||
| data: {method: methodNode.name}, | |||
| messageId: methodNode.name, | |||
There was a problem hiding this comment.
Pattern seen in
sindresorhus
approved these changes
Sep 29, 2024
fregante
changed the title
no-array-reducereduceRight alternative for no-array-reduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-array-reduce#1063