-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create publicIp
default export to return IPv6 (preference) or IPv4 (fallback)
#59
Conversation
Refers to #45 |
|
Sorry for all those "ava fix" commits. |
Now the PR is ready for merge. |
While I appreciate the pull request, this is still far from being mergable. I recommend you look over your own code and you also need to add tests and TypeScript type updates. |
@sindresorhus I've deleted the line
|
@Richienb I changed the PR according to requested. However, the |
You also need to update the types, add docs, and add tests. |
I would recommend trying to figure out the questions you asked yourself. |
If IPv6 resolves first, cancel IPv4 but if IPv4 resolves first, wait for IPv6. |
No description provided.