added global check for multimodel #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 43.89% 43.89%
=======================================
Files 129 129
Lines 14023 14026 +3
=======================================
+ Hits 6155 6157 +2
- Misses 7868 7869 +1 ☔ View full report in Codecov by Sentry. |
moyner
reviewed
Mar 19, 2024
src/multimodel/model.jl
Outdated
| @@ -858,6 +858,13 @@ function check_convergence(storage, model::MultiModel, cfg; tol = nothing, extra | |||
| err = max(e, err) | |||
| offset += number_of_degrees_of_freedom(m) ÷ model_block_size(m) | |||
| end | |||
|
|
|||
| if converged | |||
| if haskey(tol_cfg, :global_check) && !isnothing(tol_cfg[:global_check]) | |||
There was a problem hiding this comment.
Maybe it could be called global_convergence_function? We could also pass on the kwarg that contain the time and so on since that is useful for some convergence checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility for making a converge check at the level of the main model (in the case of a multimodel)