Bug fix: false negative unused var #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/111-bug-fix-combined-assignment-operators
branch
2 times, most recently
from
5cfa7c8
to
65479d5
Compare
As reported in 111, if a variable is assigned a value with a combined assignment operator, it would not be reported as unused. Includes unit tests. Fixes 111
jrfnl
force-pushed
the
feature/111-bug-fix-combined-assignment-operators
branch
2 times, most recently
from
cfa309c
to
a95ad2c
Compare
Now the `PHP_CodeSniffer\Util\Tokens` file is imported, the `Constant T_\w+ not found` errors should no longer be thrown. However, it depends on the order in which the files are analysed as that file is not (yet) `use`d in all files using the `T_` constants. If I remove the `ignoreErrors`, [the build fails](https://circleci.com/gh/sirbrillig/phpcs-variable-analysis/281) on those errors for the `VariableAnalysisSniff` file, while if I leave the exclusion in, [the build fails](https://circleci.com/gh/sirbrillig/phpcs-variable-analysis/283) on a "Ignored error not matched". So, for now, I'm leaving the ignore pattern in place and turning `reportUnmatchedIgnoredErrors` off to allow the build to pass.
|
Rebased. I've added an additional commit to allow the build to pass:
|
sirbrillig
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #111, if a variable is assigned a value with a combined assignment operator, it would not be reported as unused.
Includes unit tests.
Fixes #111