Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tsup to build project compatible with CJS and ESM, and validate in CI #258

Closed
wants to merge 6 commits into from
Closed

Use tsup to build project compatible with CJS and ESM, and validate in CI #258

wants to merge 6 commits into from

Commits on Aug 20, 2024

  1. Use tsup to build project compatible with CJS and ESM 

    With this, `npx @arethetypeswrong/cli` and `npx publint` now show as
valid, whereas the approach in
#257 was not.
    @sjdemartini
    sjdemartini committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6621d16 View commit details
    Browse the repository at this point in the history

  2. Add commonjs type in package.json to be explicit 

    Per recommendation from publint.  https://publint.dev/rules#use_type

> The package does not specify the "type" field. NodeJS may attempt to detect the package type causing a small performance hit. Consider adding "type": "commonjs".
    @sjdemartini
    sjdemartini committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9ec401c View commit details
    Browse the repository at this point in the history

  3. Add arethetypeswrong to CI to validate packaging 

    Following
JoshuaKGoldberg/create-typescript-app#1633 (comment)
    @sjdemartini
    sjdemartini committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8cdcfdb View commit details
    Browse the repository at this point in the history

  4. Add tsup config to replace ESM MUI icon imports

    @sjdemartini
    sjdemartini committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4b5e8a8 View commit details
    Browse the repository at this point in the history

  5. Add note about generating types following src directory structure

    @sjdemartini
    sjdemartini committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0ac221c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Handle lodash vs lodash-es for ESM

    @sjdemartini
    sjdemartini committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ddc0daa View commit details
    Browse the repository at this point in the history