Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RichTextEditor to update ref handle only when editor changes #261

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Update RichTextEditor to update ref handle only when editor changes #261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd3364c
Update RichTextEditor to update ref handle only when editor changes
firatoezcan Aug 21, 2024
c64ae65
Run prettier after RichTextEditor useImperativeHandle dep list fix
sjdemartini Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/RichTextEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,13 @@ const RichTextEditor = forwardRef<RichTextEditorRef, RichTextEditorProps>(
);

// Allow consumers of this component to access the editor via ref
useImperativeHandle<RichTextEditorRef, RichTextEditorRef>(ref, () => ({
editor: editor,
}));
useImperativeHandle<RichTextEditorRef, RichTextEditorRef>(
ref,
() => ({
editor: editor,
}),
[editor]
);

// Update editable state if/when it changes
useEffect(() => {
Expand Down
Loading