Skip to content

Commit

Permalink
chore(rds): add extra abstract properties to base classes to fix the …
Browse files Browse the repository at this point in the history
…build

Caused by JSII issue: aws/jsii#2040
  • Loading branch information
skinny85 committed Sep 23, 2020
1 parent c502114 commit ae0b95a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-rds/lib/cluster.ts
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@ interface DatabaseClusterBaseProps {
* A new or imported clustered database.
*/
export abstract class DatabaseClusterBase extends Resource implements IDatabaseCluster {
// only required because of JSII bug: https://github.com/aws/jsii/issues/2040
public abstract readonly engine?: IClusterEngine;

/**
* Identifier of the cluster
*/
Expand Down
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-rds/lib/instance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ export abstract class DatabaseInstanceBase extends Resource implements IDatabase
public abstract readonly dbInstanceEndpointAddress: string;
public abstract readonly dbInstanceEndpointPort: string;
public abstract readonly instanceEndpoint: Endpoint;
// only required because of JSII bug: https://github.com/aws/jsii/issues/2040
public abstract readonly engine?: IInstanceEngine;
protected abstract enableIamAuthentication?: boolean;

/**
Expand Down Expand Up @@ -1096,6 +1098,7 @@ export class DatabaseInstanceReadReplica extends DatabaseInstanceNew implements
public readonly dbInstanceEndpointAddress: string;
public readonly dbInstanceEndpointPort: string;
public readonly instanceEndpoint: Endpoint;
public readonly engine?: IInstanceEngine = undefined;
protected readonly instanceType: ec2.InstanceType;

constructor(scope: Construct, id: string, props: DatabaseInstanceReadReplicaProps) {
Expand Down

0 comments on commit ae0b95a

Please sign in to comment.