Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] CI matrix extended to windows-latest #1622

Merged
merged 9 commits into from
Aug 30, 2024
Merged

[MNT] CI matrix extended to windows-latest #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
457824f
gha test
fkiraly Aug 25, 2024
0b86712
Merge branch 'master' into windows
fkiraly Aug 25, 2024
f50f946
Merge branch 'master' into windows
fkiraly Aug 29, 2024
ec62f5d
Update test_temporal_fusion_transformer.py
fkiraly Aug 30, 2024
7d3f28f
Merge branch 'win-skip' into windows
fkiraly Aug 30, 2024
a60b3ec
Update test_temporal_fusion_transformer.py
fkiraly Aug 30, 2024
a26a252
Merge branch 'win-skip' into windows
fkiraly Aug 30, 2024
92bedd1
Update test_temporal_fusion_transformer.py
fkiraly Aug 30, 2024
9d8ea0f
Merge branch 'win-skip' into windows
fkiraly Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-13] # add windows-2019 when poetry allows installation with `-f` flag
os: [ubuntu-latest, macos-13, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]

steps:
Expand Down
8 changes: 8 additions & 0 deletions tests/test_models/test_temporal_fusion_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ def test_init_shared_network(dataloaders_with_covariates):
net.predict(dataset, fast_dev_run=True)


@pytest.mark.skipif(
sys.platform.startswith("win"),
reason="Test skipped on Windows OS due to issues with ddp, see #1623",
)
@pytest.mark.parametrize("strategy", ["ddp"])
def test_distribution(dataloaders_with_covariates, tmp_path, strategy):
train_dataloader = dataloaders_with_covariates["train"]
Expand Down Expand Up @@ -372,6 +376,10 @@ def test_prediction_with_dataframe(model, data_with_covariates):
model.predict(data_with_covariates, fast_dev_run=True)


@pytest.mark.skipif(
sys.platform.startswith("win"),
reason="Test skipped on Windows OS due to issues with ddp, see #1632",
)
@pytest.mark.parametrize("use_learning_rate_finder", [True, False])
def test_hyperparameter_optimization_integration(dataloaders_with_covariates, tmp_path, use_learning_rate_finder):
train_dataloader = dataloaders_with_covariates["train"]
Expand Down
Loading