Skip to content

Commit

Permalink
More HttpClient parameters should allow null values
Browse files Browse the repository at this point in the history 
Underlying logic already has relevant null checks.
  • Loading branch information
@abjerner
abjerner committed Jan 27, 2024
1 parent ce64b39 commit 0e36692
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/Skybrud.Essentials.Http/Client/HttpClient.Delete.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public virtual IHttpResponse Delete(string url, IHttpGetOptions options) {
/// <param name="url">The URL of the request.</param>
/// <param name="queryString">The query string of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual IHttpResponse Delete(string url, IHttpQueryString queryString) {
public virtual IHttpResponse Delete(string url, IHttpQueryString? queryString) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return GetResponse(HttpRequest.Delete(url, queryString));
}
Expand Down
2 changes: 1 addition & 1 deletion src/Skybrud.Essentials.Http/Client/HttpClient.Get.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public virtual IHttpResponse Get(string url, IHttpGetOptions options) {
/// <param name="url">The URL of the request.</param>
/// <param name="queryString">The query string of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual IHttpResponse Get(string url, IHttpQueryString queryString) {
public virtual IHttpResponse Get(string url, IHttpQueryString? queryString) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return GetResponse(HttpRequest.Get(url, queryString));
}
Expand Down
16 changes: 8 additions & 8 deletions src/Skybrud.Essentials.Http/Client/HttpClient.Patch.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public virtual IHttpResponse Patch(string url, IHttpPostOptions options) {
/// <param name="url">The base URL of the request (no query string).</param>
/// <param name="queryString">The query string.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString) {
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return GetResponse(HttpRequest.Patch(url, queryString));
}
Expand All @@ -63,7 +63,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString) {
/// <param name="url">The base URL of the request (no query string).</param>
/// <param name="postData">The POST data.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual IHttpResponse Patch(string url, IHttpPostData postData) {
public virtual IHttpResponse Patch(string url, IHttpPostData? postData) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return GetResponse(HttpRequest.Patch(url, postData));
}
Expand All @@ -75,7 +75,7 @@ public virtual IHttpResponse Patch(string url, IHttpPostData postData) {
/// <param name="queryString">The query string of the request.</param>
/// <param name="postData">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, IHttpPostData postData) {
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, IHttpPostData? postData) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return GetResponse(HttpRequest.Patch(url, queryString, postData));
}
Expand All @@ -88,7 +88,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, IHt
/// <param name="contentType">The content type of the request - eg. <c>application/json</c>.</param>
/// <param name="body">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, string contentType, string body) {
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, string contentType, string body) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return GetResponse(HttpRequest.Patch(url, queryString).SetContentType(contentType).SetBody(body));
}
Expand Down Expand Up @@ -125,7 +125,7 @@ public virtual IHttpResponse Patch(string url, JToken body, Formatting formattin
/// <param name="queryString">The query string.</param>
/// <param name="body">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, JToken body) {
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, JToken body) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return GetResponse(HttpRequest.Patch(url, queryString, body));
Expand All @@ -139,7 +139,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, JTo
/// <param name="body">The body of the request.</param>
/// <param name="formatting">The formatting to be used when serializing <paramref name="body"/>.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, JToken body, Formatting formatting) {
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, JToken body, Formatting formatting) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return GetResponse(HttpRequest.Patch(url, queryString, body, formatting));
Expand Down Expand Up @@ -177,7 +177,7 @@ public virtual IHttpResponse Patch(string url, XNode body, SaveOptions options)
/// <param name="queryString">The query string.</param>
/// <param name="body">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, XNode body) {
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, XNode body) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return GetResponse(HttpRequest.Patch(url, queryString, body));
Expand All @@ -191,7 +191,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, XNo
/// <param name="body">The body of the request.</param>
/// <param name="options">The options to be used when serializing <paramref name="body"/>.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, XNode body, SaveOptions options) {
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, XNode body, SaveOptions options) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return GetResponse(HttpRequest.Patch(url, queryString, body, options));
Expand Down
2 changes: 1 addition & 1 deletion src/Skybrud.Essentials.Http/Client/HttpClient.Put.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public virtual IHttpResponse Put(string url, IHttpPostData? postData) {
/// <param name="queryString">The query string of the request.</param>
/// <param name="postData">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual IHttpResponse Put(string url, IHttpQueryString? queryString, IHttpPostData postData) {
public virtual IHttpResponse Put(string url, IHttpQueryString? queryString, IHttpPostData? postData) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return GetResponse(HttpRequest.Put(url, queryString, postData));
}
Expand Down
2 changes: 1 addition & 1 deletion src/Skybrud.Essentials.Http/Client/HttpClientAsync.Get.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public virtual async Task<IHttpResponse> GetAsync(string url) {
/// <param name="url">The URL of the request.</param>
/// <param name="queryString">The query string of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual async Task<IHttpResponse> GetAsync(string url, IHttpQueryString queryString) {
public virtual async Task<IHttpResponse> GetAsync(string url, IHttpQueryString? queryString) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return await GetResponseAsync(HttpRequest.Get(url, queryString));
}
Expand Down
16 changes: 8 additions & 8 deletions src/Skybrud.Essentials.Http/Client/HttpClientAsync.Patch.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url) {
/// <param name="url">The base URL of the request (no query string).</param>
/// <param name="queryString">The query string.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return await GetResponseAsync(HttpRequest.Patch(url, queryString));
}
Expand All @@ -38,7 +38,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
/// <param name="url">The base URL of the request (no query string).</param>
/// <param name="postData">The POST data.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpPostData postData) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpPostData? postData) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return await GetResponseAsync(HttpRequest.Patch(url, postData));
}
Expand All @@ -50,7 +50,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpPostData po
/// <param name="queryString">The query string of the request.</param>
/// <param name="postData">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, IHttpPostData postData) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, IHttpPostData? postData) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return await GetResponseAsync(HttpRequest.Patch(url, queryString, postData));
}
Expand All @@ -63,7 +63,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
/// <param name="contentType">The content type of the request - eg. <c>application/json</c>.</param>
/// <param name="body">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, string contentType, string body) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, string contentType, string body) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
return await GetResponseAsync(HttpRequest.Patch(url, queryString).SetContentType(contentType).SetBody(body));
}
Expand Down Expand Up @@ -100,7 +100,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, JToken body, For
/// <param name="queryString">The query string.</param>
/// <param name="body">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, JToken body) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, JToken body) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body));
Expand All @@ -114,7 +114,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
/// <param name="body">The body of the request.</param>
/// <param name="formatting">The formatting to be used when serializing <paramref name="body"/>.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, JToken body, Formatting formatting) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, JToken body, Formatting formatting) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body, formatting));
Expand Down Expand Up @@ -152,7 +152,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, XNode body, Save
/// <param name="queryString">The query string.</param>
/// <param name="body">The body of the request.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, XNode body) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, XNode body) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body));
Expand All @@ -166,7 +166,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
/// <param name="body">The body of the request.</param>
/// <param name="options">The options to be used when serializing <paramref name="body"/>.</param>
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, XNode body, SaveOptions options) {
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, XNode body, SaveOptions options) {
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
if (body == null) throw new ArgumentNullException(nameof(body));
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body, options));
Expand Down

0 comments on commit 0e36692

Please sign in to comment.